If the photo square and frame are 2 separate layers, make sure you're putting your photo above the photo square layer, not the frame one. This way, when you do the clipping mask, it'll clip to the photo area and will be on top of the frame.

__________________
Daisy